Move from MailDateFormat (not thread safe) to DateTimeFormatter #590 #713
Conversation
…taee#590 Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
| return mailDateFormat.parse(s); | ||
| } | ||
| } catch (ParseException pex) { | ||
| return Date.from(Instant.from(mailDateFormat.parse(s))); |
There was a problem hiding this comment.
MailDateFormat has a concept of isLenient and per the API documents it was not clear to me if the default is lenient or strict. I wonder if you need to use withResolverStyle to set that behavior and how compatible with existing behavior, mainly with parsing of dates.
Looking at the MailDateFormatTest there are some tests that seem to imply leniency with lots of exceptions:
- lenientMustBeBackwardCompatible()
- mustUseLeniencyForParsing()
- mustFailOrSkipCfws()
- lenientMustAcceptNonMilitaryZoneNames()
I would think that for testing this version of the patch you would need to port the MailDateFormatTest into the MimeMessageTest. Which seems like a lot of work.
What are your thoughts on just getting rid of the static field and the synchronized block and just creating some method local garbage by just creating a new MailDateFormat for parsing and formatting?
|
I don't see a feasible way to replace MailDateFormat, and it has many specifics. Probably moving to DateTimeFormatter is not the way to go. |
#590
I only saw references in
MimeMessage. I updated that class to not useMailDateFormat.